-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #134812
Rollup of 8 pull requests #134812
Conversation
…te keys. This behavior is worth documenting because there are other plausible alternatives, such as panicking when a duplicate is encountered, and it reminds the programmer to consider whether they should, for example, coalesce duplicate keys first.
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
This removes boilerplate around `Arc`s and makes the code more clear.
With rust-lang#80608 the `unwinding` crate no longer builds. The upstream crate has been updated to build by manually adding directives to the naked_asm stream. Bump the dependency in Rust to get this newer version. This fixes the build for Xous, and closes rust-lang#134403. Signed-off-by: Sean Cross <sean@xobs.io>
Rustdoc has no way to show that an item is stable, but only at a different path. `std::ffi::c_str::NulError` is not stable, but `std::ffi::NulError` is. To avoid marking these types as unstable when someone just wants to follow a link from `CString`, inline them into their stable paths.
…kang [macro_metavar_expr_concat] Fix rust-lang#128346 Fix rust-lang#128346 Fix rust-lang#131393 The syntax is invalid in both issues so I guess that theoretically the compiler should have aborted early. This PR tries to fix a local problem but let me know if there are better options. cc `@petrochenkov` if you are interested
Add `into_array` conversion destructors for `Box`, `Rc`, and `Arc`. Tracking issue: rust-lang#133508 This PR adds the `into_array` destructor for `alloc::boxed::Box<[T]>`, `alloc::rc::Rc<[T]>`, and `alloc::sync::Arc<[T]>`. Note that this PR assumes the initial proposal of these functions returning `Option`. It is still an open question whether this should instead be `Result`. We can, however, easily change this in a follow-up PR with the necessary consensus.
Document collection `From` and `FromIterator` impls that drop duplicate keys. This behavior is worth documenting because there are other plausible alternatives, such as panicking when a duplicate is encountered, and it reminds the programmer to consider whether they should, for example, coalesce duplicate keys first. Followup to rust-lang#89869.
Fix forgetting to save statx availability on success Looks like we forgot to save the statx state on success which means the first failure (common when checking if a file exists) will always require spending an invalid statx to confirm the failure is real. r? `@thomcc`
Use scoped threads in `std::sync::Barrier` examples This removes boilerplate around `Arc`s and makes the code more clear.
…ark-Simulacrum Update Code Example for `Iterator::rposition` Added an additional assertion to the example to show the behavior of `iter.next_back` after using `iter.rposition`.
…5.0, r=Mark-Simulacrum unwinding: bump version to fix naked_asm on Xous With rust-lang#80608 the `unwinding` crate no longer builds. The upstream crate has been updated to build by manually adding directives to the naked_asm stream. Bump the dependency in Rust to get this newer version. This fixes the build for Xous, and closes rust-lang#134403.
…or-types, r=tgross35 docs: inline `std::ffi::c_str` types to `std::ffi` Rustdoc has no way to show that an item is stable, but only at a different path. `std::ffi::c_str::NulError` is not stable, but `std::ffi::NulError` is. To avoid marking these types as unstable when someone just wants to follow a link from `CString`, inline them into their stable paths. Fixes rust-lang#134702 r? `@tgross35`
@bors r+ rollup=never p=5 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR:
previous master: 917bfa7847 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (207ed1b): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 1.4%, secondary -0.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 764.398s -> 763.9s (-0.07%) |
Rollup of 8 pull requests Successful merges: - rust-lang#131522 ([macro_metavar_expr_concat] Fix rust-lang#128346) - rust-lang#134379 (Add `into_array` conversion destructors for `Box`, `Rc`, and `Arc`.) - rust-lang#134644 (Document collection `From` and `FromIterator` impls that drop duplicate keys.) - rust-lang#134649 (Fix forgetting to save statx availability on success) - rust-lang#134728 (Use scoped threads in `std::sync::Barrier` examples) - rust-lang#134782 (Update Code Example for `Iterator::rposition`) - rust-lang#134789 (unwinding: bump version to fix naked_asm on Xous) - rust-lang#134791 (docs: inline `std::ffi::c_str` types to `std::ffi`) r? `@ghost` `@rustbot` modify labels: rollup
Successful merges:
None
#128346)into_array
conversion destructors forBox
,Rc
, andArc
. #134379 (Addinto_array
conversion destructors forBox
,Rc
, andArc
.)From
andFromIterator
impls that drop duplicate keys. #134644 (Document collectionFrom
andFromIterator
impls that drop duplicate keys.)std::sync::Barrier
examples #134728 (Use scoped threads instd::sync::Barrier
examples)Iterator::rposition
#134782 (Update Code Example forIterator::rposition
)std::ffi::c_str
types tostd::ffi
#134791 (docs: inlinestd::ffi::c_str
types tostd::ffi
)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup