Implement normalize_lexically
#134696
Open
Implement normalize_lexically
#134696
+121
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @workingjubilee. Use |
rustbot
added
S-waiting-on-review
4 tasks
ChrisDenton
force-pushed
the
normalize-lexically
branch
from
29237f0 to
c08079c
Compare
ChrisDenton
force-pushed
the
normalize-lexically
branch
from
c08079c to
8a3fb66
Compare
|
|
||
| for component in iter { | ||
| match component { | ||
| Component::RootDir | Component::Prefix(_) => return Err(NormalizeError), |
There was a problem hiding this comment.
Shouldn't Component::RootDir be unreachable? (We just checked it and skipped it.)
Comment on lines
+3014
to
+3018
| Component::RootDir | Component::Prefix(_) => return Err(NormalizeError), | ||
| Component::CurDir => continue, | ||
| Component::ParentDir => { | ||
| if lexical.as_os_str().len() == root { | ||
| return Err(NormalizeError); |
There was a problem hiding this comment.
This is also a "should never happen" case, isn't it?
workingjubilee
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #134694
This is, I think, the most straightforward implementation I could do, which will hopefully more easily allow experimentation if we decide to change the design here.