Don't ICE on illegal dyn* casts
#134635
Merged
Don't ICE on illegal dyn* casts
#134635
+52
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
fmease
approved these changes
Dec 22, 2024
| @@ -721,13 +721,11 @@ impl<'a, 'tcx> CastCheck<'tcx> { | |||
| use rustc_middle::ty::cast::IntTy::*; | |||
|
|
|||
| if self.cast_ty.is_dyn_star() { | |||
There was a problem hiding this comment.
Honestly, this should probably be self.expr_ty.is_dyn_star() || self.cast_ty.is_dyn_star() to fix the diagnostic regression from 46ecb23 that affects tests/ui/dyn-star/dyn-to-rigid.rs.
|
Thanks! @bors r+ rollup (unstable) |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 22, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#134599 (Detect invalid exprs in parser used by pretty-printer tests) - rust-lang#134602 (Document `PointerLike` implementation restrictions.) - rust-lang#134635 (Don't ICE on illegal `dyn*` casts) - rust-lang#134639 (Make sure we note ambiguity causes on positive/negative impl conflicts) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 22, 2024
Rollup merge of rust-lang#134635 - compiler-errors:dyn-dyn, r=fmease Don't ICE on illegal `dyn*` casts Fixes rust-lang#134544 Fixes rust-lang#132127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134544
Fixes #132127