-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new {x86_64,i686}-win7-windows-gnu
targets
#134609
base: master
Are you sure you want to change the base?
Conversation
Failed to set assignee to
|
Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb These commits modify compiler targets. |
r? compiler |
This comment has been minimized.
This comment has been minimized.
CC @roblabla, I tried sending you an email over this, but didn't receive an answer. |
compiler/rustc_target/src/spec/targets/x86_64_win7_windows_gnu.rs
Outdated
Show resolved
Hide resolved
Sorry, had a bit of a busy week. To answer your question on why I didn't do a -gnu/-gnullvm target, it's rather simple: I don't need them, and didn't want to increase my maintenance workload with things I don't need ^^. For the most part, I don't expect there to be any major roadblocks, however. Nearly all of the effort to support the win7 target will benefit both the msvc and the gnu/gnullvm target, as they're mostly about maintaining some backward compatibility codepaths in libstd. |
☔ The latest upstream changes (presumably #134677) made this pull request unmergeable. Please resolve the merge conflicts. |
These are in symmetry with `{x86_64,i686}-win7-windows-msvc`.
These are in symmetry with
{x86_64,i686}-win7-windows-msvc
.This is me, @tbu- on github.
Consistent with
{x86_64,i686}-win7-windows-msvc
, see also #118150.AFAICT, it's the same legal situation as the tier 1
{x86_64,i686}-pc-windows-gnu
.Understood.
This target supports the whole libstd surface, since it's essentially reusing all of the x86_64-pc-windows-gnu target. Understood.
I tried to write some documentation on that.
Understood.
Understood.
Understood.
r? compiler-team