Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Fuchsia toolchain for testing #134581

Merged
merged 1 commit into from
Dec 22, 2024
Merged

Bump Fuchsia toolchain for testing #134581

merged 1 commit into from
Dec 22, 2024

Conversation

erickt
Copy link
Contributor

@erickt erickt commented Dec 20, 2024

This updates the Fuchsia SDK used to test rust on Fuchsia to 26.20241211.7.1, and clang to the development version 20 from 388d7f144880dcd85ff31f06793304405a9f44b6.

@steven807 asked me to take over the PR. Since I don't have commit access to his repo, I just cherry picked his patch here.

try-job: dist-various-2

r? lqd

This updates the Fuchsia SDK used to test rust on Fuchsia to
26.20241211.7.1, and clang to the development version 20 from
388d7f144880dcd85ff31f06793304405a9f44b6.
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 20, 2024
@erickt erickt mentioned this pull request Dec 20, 2024
@erickt
Copy link
Contributor Author

erickt commented Dec 20, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024
Bump Fuchsia toolchain for testing

This updates the Fuchsia SDK used to test rust on Fuchsia to 26.20241211.7.1, and clang to the development version 20 from 388d7f144880dcd85ff31f06793304405a9f44b6.

`@steven807` asked me to take over the PR. Since I don't have commit access to his repo, I just cherry picked his patch here.

r? lqd
@bors
Copy link
Contributor

bors commented Dec 20, 2024

⌛ Trying commit a93c95b with merge 1d55d1f...

@lqd
Copy link
Member

lqd commented Dec 20, 2024

What builder did you need to try: should it have been dist-various-2 like the previous PR, instead of the default one (dist x64 linux) like here?

@erickt
Copy link
Contributor Author

erickt commented Dec 20, 2024

Good point, it does! I edited into my initial message. Will re-running the bors try job pick it up automatically, or do I need it in the commit message? I don't want to waste CI with another bors try run if I got it wrong.

@bors
Copy link
Contributor

bors commented Dec 20, 2024

☀️ Try build successful - checks-actions
Build commit: 1d55d1f (1d55d1fd1e8af3bff73931b2e9ce9f8919019f93)

@lqd
Copy link
Member

lqd commented Dec 20, 2024

It should pick it up automatically, no need for a new commit :)

@bors try

@bors
Copy link
Contributor

bors commented Dec 20, 2024

⌛ Trying commit a93c95b with merge 3f7b94f...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024
Bump Fuchsia toolchain for testing

This updates the Fuchsia SDK used to test rust on Fuchsia to 26.20241211.7.1, and clang to the development version 20 from 388d7f144880dcd85ff31f06793304405a9f44b6.

`@steven807` asked me to take over the PR. Since I don't have commit access to his repo, I just cherry picked his patch here.

try-job: dist-various-2

r? lqd
@bors
Copy link
Contributor

bors commented Dec 21, 2024

☀️ Try build successful - checks-actions
Build commit: 3f7b94f (3f7b94f564888d1a1c90ba1dcdabd987f2f3db46)

@lqd
Copy link
Member

lqd commented Dec 21, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 21, 2024

📌 Commit a93c95b has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 21, 2024
DianQK added a commit to DianQK/rust that referenced this pull request Dec 21, 2024
Bump Fuchsia toolchain for testing

This updates the Fuchsia SDK used to test rust on Fuchsia to 26.20241211.7.1, and clang to the development version 20 from 388d7f144880dcd85ff31f06793304405a9f44b6.

`@steven807` asked me to take over the PR. Since I don't have commit access to his repo, I just cherry picked his patch here.

try-job: dist-various-2

r? lqd
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 21, 2024
Bump Fuchsia toolchain for testing

This updates the Fuchsia SDK used to test rust on Fuchsia to 26.20241211.7.1, and clang to the development version 20 from 388d7f144880dcd85ff31f06793304405a9f44b6.

``@steven807`` asked me to take over the PR. Since I don't have commit access to his repo, I just cherry picked his patch here.

try-job: dist-various-2

r? lqd
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 21, 2024
Rollup of 6 pull requests

Successful merges:

 - rust-lang#131072 (Win: Use POSIX rename semantics for `std::fs::rename` if available)
 - rust-lang#134325 (Correctly document CTFE behavior of is_null and methods that call is_null.)
 - rust-lang#134526 (update `rustc_index_macros` feature handling)
 - rust-lang#134581 (Bump Fuchsia toolchain for testing)
 - rust-lang#134607 (on pair → on par)
 - rust-lang#134608 (Move test rust-lang#93775 to crashes)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 22, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#131072 (Win: Use POSIX rename semantics for `std::fs::rename` if available)
 - rust-lang#134325 (Correctly document CTFE behavior of is_null and methods that call is_null.)
 - rust-lang#134526 (update `rustc_index_macros` feature handling)
 - rust-lang#134581 (Bump Fuchsia toolchain for testing)
 - rust-lang#134607 (on pair → on par)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 22de6f6 into rust-lang:master Dec 22, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 22, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 22, 2024
Rollup merge of rust-lang#134581 - erickt:bump_sdk, r=lqd

Bump Fuchsia toolchain for testing

This updates the Fuchsia SDK used to test rust on Fuchsia to 26.20241211.7.1, and clang to the development version 20 from 388d7f144880dcd85ff31f06793304405a9f44b6.

```@steven807``` asked me to take over the PR. Since I don't have commit access to his repo, I just cherry picked his patch here.

try-job: dist-various-2

r? lqd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants