miri: avoid making a full copy of all new allocations #125633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
The Miri subtree was changed cc @rust-lang/miri Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
RalfJung
force-pushed
the
miri-no-copy
branch
2 times, most recently
from
5e03c8f to
14801af
Compare
saethlin
reviewed
May 27, 2024
Comment on lines
+346
to
+349
| // The default implementation does a copy; CTFE machines have a more efficient implementation | ||
| // based on their particular choice for `Provenance`, `AllocExtra`, and `Bytes`. | ||
| let kind = Self::GLOBAL_KIND | ||
| .expect("if GLOBAL_KIND is None, adjust_global_allocation must be overwritten"); |
There was a problem hiding this comment.
🤨 So the implementation that Miri needs is the default, and the const fn interpreter overrides with something simpler? Don't we usually do things the other way around?
There was a problem hiding this comment.
Yeah, but the other way around does not work here and the const-eval interpreter impl is not well-typed in general, in relies on specific choices for the associated type. And meanwhile it seems nice that a default impl is possible.
There was a problem hiding this comment.
I see. It's always ironic when we run into loose typing implementing Rust.
There was a problem hiding this comment.
To me this is actually a sign of a pretty powerful type system -- in the const-eval implementation we of course know more about the concrete choice of types than in the general trait definition, and that lets us safely convert between types that are in general inequal, but are known to be equal in this concrete instance.
|
@bors r+ |
bors
added
S-waiting-on-bors
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
May 28, 2024
miri: avoid making a full copy of all new allocations Hopefully fixes rust-lang/miri#3637 r? `@saethlin`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 29, 2024
Rollup of 8 pull requests Successful merges: - rust-lang#124251 (Add an intrinsic for `ptr::metadata`) - rust-lang#124320 (Add `--print=check-cfg` to get the expected configs) - rust-lang#125226 (Make more of the test suite run on Mac Catalyst) - rust-lang#125381 (Silence some resolve errors when there have been glob import errors) - rust-lang#125633 (miri: avoid making a full copy of all new allocations) - rust-lang#125638 (Rewrite `lto-smoke`, `simple-rlib` and `mixing-deps` `run-make` tests in `rmake.rs` format) - rust-lang#125639 (Support `./x doc run-make-support --open`) - rust-lang#125664 (Tweak relations to no longer rely on `TypeTrace`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 29, 2024
Rollup of 8 pull requests Successful merges: - rust-lang#124251 (Add an intrinsic for `ptr::metadata`) - rust-lang#124320 (Add `--print=check-cfg` to get the expected configs) - rust-lang#125226 (Make more of the test suite run on Mac Catalyst) - rust-lang#125381 (Silence some resolve errors when there have been glob import errors) - rust-lang#125633 (miri: avoid making a full copy of all new allocations) - rust-lang#125638 (Rewrite `lto-smoke`, `simple-rlib` and `mixing-deps` `run-make` tests in `rmake.rs` format) - rust-lang#125639 (Support `./x doc run-make-support --open`) - rust-lang#125664 (Tweak relations to no longer rely on `TypeTrace`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 29, 2024
Rollup merge of rust-lang#125633 - RalfJung:miri-no-copy, r=saethlin miri: avoid making a full copy of all new allocations Hopefully fixes rust-lang/miri#3637 r? ``@saethlin``
bors
added a commit
to rust-lang/miri
that referenced
this pull request
May 29, 2024
Add a benchmark for creating large uninit allocations Extracted from #3637 I used this program to confirm that rust-lang/rust#125633 has the desired effect.
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Jun 9, 2024
Add a benchmark for creating large uninit allocations Extracted from rust-lang/miri#3637 I used this program to confirm that rust-lang#125633 has the desired effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes rust-lang/miri#3637
r? @saethlin