Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update compiler_builtins to 0.1.109 #123719

Merged
merged 1 commit into from
Apr 14, 2024
Merged

update compiler_builtins to 0.1.109 #123719

merged 1 commit into from
Apr 14, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Apr 10, 2024 •
edited
Loading

This pulls in rust-lang/compiler-builtins#583 so we should make sure that does not come with any perf surprises.

Cc @Amanieu

@rustbot
Copy link
Collaborator

rustbot commented Apr 10, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 10, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 10, 2024

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@RalfJung
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 10, 2024
@bors
Copy link
Contributor

bors commented Apr 10, 2024

⌛ Trying commit 385c363 with merge 4e5df4d...

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 10, 2024
@bors
Auto merge of rust-lang#123719 - RalfJung:compiler_builtins, r=<try>
4e5df4d 
update compiler_builtins to 0.1.109

This pulls in rust-lang/compiler-builtins#583 so we should make sure that does not come with any perf surprises.

Cc `@Amanieu`
@bors
Copy link
Contributor

bors commented Apr 10, 2024

☀️ Try build successful - checks-actions
Build commit: 4e5df4d (4e5df4d944249b5cdc120cbbc93f85165ec6c8de)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4e5df4d): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.1% [3.1%, 3.1%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.7% [-2.7%, -2.7%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.2% [-2.7%, 3.1%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.485s -> 674.163s (-0.05%)
Artifact size: 318.39 MiB -> 318.36 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 10, 2024
@jeremyd2019 jeremyd2019 mentioned this pull request Apr 10, 2024
Merged
@RalfJung RalfJung mentioned this pull request Apr 13, 2024
Merged
@RalfJung
Copy link
Member Author

That looks good. :)

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 13, 2024

📌 Commit 385c363 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2024
@bors
Copy link
Contributor

bors commented Apr 13, 2024

⌛ Testing commit 385c363 with merge 5525627...

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 13, 2024
@bors
Auto merge of rust-lang#123719 - RalfJung:compiler_builtins, r=Mark-S…
5525627 
…imulacrum

update compiler_builtins to 0.1.109

This pulls in rust-lang/compiler-builtins#583 so we should make sure that does not come with any perf surprises.

Cc `@Amanieu`
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
[RUSTC-TIMING] lazy_static test:false 0.108
[RUSTC-TIMING] build_script_build test:false 0.684
   Compiling derive_more v0.99.17
   Compiling darling_core v0.20.8
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

@bors
Copy link
Contributor

bors commented Apr 14, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 14, 2024
@RalfJung
Copy link
Member Author

@bors retry " Error: The operation was canceled."

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 14, 2024
@bors
Auto merge of rust-lang#123719 - RalfJung:compiler_builtins, r=Mark-S…
4a0cacd 
…imulacrum

update compiler_builtins to 0.1.109

This pulls in rust-lang/compiler-builtins#583 so we should make sure that does not come with any perf surprises.

Cc `@Amanieu`
@bors
Copy link
Contributor

bors commented Apr 14, 2024

⌛ Testing commit 385c363 with merge 4a0cacd...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-aux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Apr 14, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 14, 2024
@RalfJung
Copy link
Member Author

Looks like an instance of #123583.
@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2024
@bors
Copy link
Contributor

bors commented Apr 14, 2024

⌛ Testing commit 385c363 with merge 29b1207...

@bors
Copy link
Contributor

bors commented Apr 14, 2024

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 29b1207 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Apr 14, 2024

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 29b1207 to master...

@bors bors added merged-by-bors This PR was explicitly merged by bors. labels Apr 14, 2024
@bors bors merged commit 29b1207 into rust-lang:master Apr 14, 2024
12 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 14, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (29b1207): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.2% [1.2%, 1.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.5% [-2.5%, -2.5%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 677.239s -> 677.423s (0.03%)
Artifact size: 315.99 MiB -> 316.04 MiB (0.01%)

@RalfJung RalfJung mentioned this pull request Apr 15, 2024
Merged
@RalfJung RalfJung deleted the compiler_builtins branch April 16, 2024 05:53
@fenhl fenhl mentioned this pull request Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
6 participants
@RalfJung @rustbot @rust-timer @bors @Mark-Simulacrum @rust-log-analyzer