Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix suggestion when shorthand self has erroneous type #122161

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fix suggestion when shorthand self has erroneous type #122161

merged 1 commit into from
Dec 5, 2024

Conversation

compiler-errors
Copy link
Member

Fixes #122086

r? estebank

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 8, 2024
@chenyukang chenyukang mentioned this pull request Mar 8, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 8, 2024
@matthiaskrgr
Rollup merge of rust-lang#122175 - chenyukang:yukang-fix-tidy-issues,…
af3d06c 
… r=workingjubilee

Bless tidy issues order

The order is not right now because of rust-lang#121248 (comment)

from rust-lang#122161 (comment)

r? `@workingjubilee`
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 8, 2024
@rust-timer
Unrolled build for rust-lang#122175
1f4c0e1 
Rollup merge of rust-lang#122175 - chenyukang:yukang-fix-tidy-issues, r=workingjubilee

Bless tidy issues order

The order is not right now because of rust-lang#121248 (comment)

from rust-lang#122161 (comment)

r? `@workingjubilee`
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Mar 9, 2024
@matthiaskrgr
Rollup merge of #122175 - chenyukang:yukang-fix-tidy-issues, r=workin…
5e07420 
…gjubilee

Bless tidy issues order

The order is not right now because of rust-lang/rust#121248 (comment)

from rust-lang/rust#122161 (comment)

r? `@workingjubilee`
@compiler-errors
Copy link
Member Author

Seems like @estebank is busy, so

r? compiler

@rustbot rustbot assigned michaelwoerister and unassigned estebank Mar 19, 2024
@compiler-errors
Copy link
Member Author

r? @fmease

@rustbot rustbot assigned fmease and unassigned michaelwoerister Mar 19, 2024
fmease
fmease approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@fmease fmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I like it! I have some smol nitpicks.

compiler/rustc_parse/src/parser/item.rs Outdated Show resolved Hide resolved
compiler/rustc_parse/src/parser/item.rs Outdated Show resolved Hide resolved
compiler/rustc_ast/src/ast.rs Outdated Show resolved Hide resolved
compiler/rustc_ast/src/ast.rs Outdated Show resolved Hide resolved
compiler/rustc_ast/src/ast.rs Show resolved Hide resolved
@fmease fmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2024
@bors
Copy link
Contributor

bors commented Apr 23, 2024

☔ The latest upstream changes (presumably #124277) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnCSimon
Copy link
Member

@compiler-errors
ping from triage - can you post your status on this PR? This PR has not received an update in a few months.

@compiler-errors
Copy link
Member Author

Ya I'll rebase it.

@alex-semenyuk alex-semenyuk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 30, 2024
@compiler-errors
Copy link
Member Author

Finally rebased lol

@bors r=fmease

@compiler-errors
Copy link
Member Author

@bors r=fmease

@compiler-errors
Copy link
Member Author

@bors ping

@bors
Copy link
Contributor

bors commented Dec 4, 2024

😪 I'm awake I'm awake

@compiler-errors
Copy link
Member Author

ok so if you're awake then why won't you accept my pr

@bors r=fmease

@bors
Copy link
Contributor

bors commented Dec 4, 2024

📌 Commit 05c34cc has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 4, 2024
@bors
Copy link
Contributor

bors commented Dec 4, 2024

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Dec 4, 2024

📌 Commit 05c34cc has been approved by fmease

It is now in the queue for this repository.

fmease added a commit to fmease/rust that referenced this pull request Dec 4, 2024
@fmease
Rollup merge of rust-lang#122161 - compiler-errors:shorthand-self, r=…
be189d0 
…fmease

Fix suggestion when shorthand `self` has erroneous type

Fixes rust-lang#122086

r? estebank
@fmease fmease mentioned this pull request Dec 4, 2024
Closed
fmease added a commit to fmease/rust that referenced this pull request Dec 4, 2024
@fmease
Rollup merge of rust-lang#122161 - compiler-errors:shorthand-self, r=…
81bbc9c 
…fmease

Fix suggestion when shorthand `self` has erroneous type

Fixes rust-lang#122086

r? estebank
@fmease fmease mentioned this pull request Dec 4, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 4, 2024
@bors
Auto merge of rust-lang#133877 - fmease:rollup-909elhb, r=fmease
f54d5f3 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#118833 (Add lint against function pointer comparisons)
 - rust-lang#122161 (Fix suggestion when shorthand `self` has erroneous type)
 - rust-lang#133233 (Add context to "const in pattern" errors)
 - rust-lang#133843 (Do not emit empty suggestion)
 - rust-lang#133863 (Rename `core_pattern_type` and `core_pattern_types` lib feature  gates to `pattern_type_macro`)
 - rust-lang#133872 (No need to create placeholders for GAT args in confirm_object_candidate)
 - rust-lang#133874 (`fn_sig_for_fn_abi` should return a `ty::FnSig`, no need for a binder)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 5, 2024
@bors
Auto merge of rust-lang#133877 - fmease:rollup-909elhb, r=fmease
40a662e 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#118833 (Add lint against function pointer comparisons)
 - rust-lang#122161 (Fix suggestion when shorthand `self` has erroneous type)
 - rust-lang#133233 (Add context to "const in pattern" errors)
 - rust-lang#133843 (Do not emit empty suggestion)
 - rust-lang#133863 (Rename `core_pattern_type` and `core_pattern_types` lib feature  gates to `pattern_type_macro`)
 - rust-lang#133872 (No need to create placeholders for GAT args in confirm_object_candidate)
 - rust-lang#133874 (`fn_sig_for_fn_abi` should return a `ty::FnSig`, no need for a binder)

r? `@ghost`
`@rustbot` modify labels: rollup
@fmease fmease mentioned this pull request Dec 5, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 5, 2024
@bors
Auto merge of rust-lang#133893 - fmease:rollup-11pi6fg, r=fmease
0e98766 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#118833 (Add lint against function pointer comparisons)
 - rust-lang#122161 (Fix suggestion when shorthand `self` has erroneous type)
 - rust-lang#133233 (Add context to "const in pattern" errors)
 - rust-lang#133761 (Update books)
 - rust-lang#133843 (Do not emit empty suggestion)
 - rust-lang#133863 (Rename `core_pattern_type` and `core_pattern_types` lib feature  gates to `pattern_type_macro`)
 - rust-lang#133872 (No need to create placeholders for GAT args in confirm_object_candidate)
 - rust-lang#133874 (`fn_sig_for_fn_abi` should return a `ty::FnSig`, no need for a binder)
 - rust-lang#133890 (Add a new test ui/incoherent-inherent-impls/no-other-unrelated-errors to check E0116 does not cause unrelated errors)
 - rust-lang#133892 (Revert rust-lang#133817)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bc13c82 into rust-lang:master Dec 5, 2024
7 of 12 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 5, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 5, 2024
@rust-timer
Unrolled build for rust-lang#122161
5d565d1 
Rollup merge of rust-lang#122161 - compiler-errors:shorthand-self, r=fmease

Fix suggestion when shorthand `self` has erroneous type

Fixes rust-lang#122086

r? estebank
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workingjubilee workingjubilee workingjubilee left review comments

@chenyukang chenyukang chenyukang left review comments

@fmease fmease fmease approved these changes

Assignees

@fmease fmease

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.

self param with ampersand (&) and explicit type yields noisy parsing diagnostics which could be more helpful
10 participants
@compiler-errors @bors @JohnCSimon @chenyukang @fmease @workingjubilee @estebank @michaelwoerister @alex-semenyuk @rustbot