Rollup of 6 pull requests #102867

JohnTitor · 2022-10-10T01:23:07Z

Successful merges:

Stabilize half_open_range_patterns #102275 (Stabilize half_open_range_patterns)
Trying to suggest additional lifetime parameter #102323 (Trying to suggest additional lifetime parameter)
Recover from impl Trait in type param bound #102345 (Recover from impl Trait in type param bound)
Elaborate trait ref to compute object safety. #102845 (Elaborate trait ref to compute object safety.)
Add missing documentation for FileNameDisplayPreference variants #102860 (Add missing documentation for FileNameDisplayPreference variants)
From<Alignment> for usize & NonZeroUsize #102862 (From for usize & NonZeroUsize)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

…tterns, r=cjgillot Stabilize `half_open_range_patterns` This PR stabilize `feature(half_open_range_patterns)`: ``` Allows using `..=X` as a pattern. ``` And adds a new `feature(half_open_range_patterns_in_slices)` for the slice part, rust-lang#102275 (comment). The FCP was completed in rust-lang#67264.

Trying to suggest additional lifetime parameter ``@cjgillot`` This is what I have so far for rust-lang#100615

…r=estebank Recover from impl Trait in type param bound Fixes rust-lang#102182 r? ``@estebank``

Elaborate trait ref to compute object safety. instead of building them manually from supertraits and associated items. This allows to have the correct substs for GATs. Fixes rust-lang#102751

…meDisplayPreference, r=nagisa Add missing documentation for FileNameDisplayPreference variants Took me a while to find the information when I needed it so hopefully it should save some time for the next ones. r? ``@thomcc``

…thomcc From<Alignment> for usize & NonZeroUsize Since you mentioned these two in rust-lang#102072 (comment), r? ``@thomcc`` Tracking Issue: rust-lang#102070

JohnTitor · 2022-10-10T01:23:19Z

@bors r+ p=6 rollup=never

bors · 2022-10-10T01:23:21Z

📌 Commit 6d35efe has been approved by JohnTitor

It is now in the queue for this repository.

bors · 2022-10-10T03:20:07Z

⌛ Testing commit 6d35efe with merge e495b37...

bors · 2022-10-10T06:18:51Z

☀️ Test successful - checks-actions
Approved by: JohnTitor
Pushing e495b37 to master...

rust-timer · 2022-10-10T06:21:03Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#102862	5fb6631acabad5edcd2a997ca492f70d0260128a
#102860	2b9a757a280f92754c6d1759b44b78a3a86672e5
#102845	a892a73217a8859ad3ec076292dd5c872f4fc473
#102345	f8a85b85c456e96a16e5b59a1c2b2751c70edcfa
#102323	4a627b7553575ba13efa4505dd252b24f2eba8ac
#102275	33374cb4941ebecd4b63936b7afb52542b2d1bbf

previous master: 1a7c203e7f

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2022-10-10T07:37:51Z

Finished benchmarking commit (e495b37): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	0.3%	[0.3%, 0.4%]	6
Regressions ❌ (secondary)	1.4%	[1.2%, 1.6%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	0.3%	[0.3%, 0.4%]	6

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	6.4%	[6.4%, 6.4%]	1
Regressions ❌ (secondary)	2.3%	[2.3%, 2.3%]	3
Improvements ✅ (primary)	-0.8%	[-0.8%, -0.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.8%	[-0.8%, 6.4%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

the arithmetic mean of the percent change ↩ ↩²
number of relevant changes ↩ ↩²

rylev · 2022-10-11T14:20:37Z

the impacted benchmarks are more sensitive to changes to the trait system, so it looks like it might be #102845

@rust-timer build a892a73217a8859ad3ec076292dd5c872f4fc473

rust-timer · 2022-10-11T14:20:39Z

Queued a892a73217a8859ad3ec076292dd5c872f4fc473 with parent 1a7c203, future comparison URL.

rust-timer · 2022-10-11T16:52:48Z

Finished benchmarking commit (a892a73217a8859ad3ec076292dd5c872f4fc473): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	0.3%	[0.3%, 0.6%]	7
Regressions ❌ (secondary)	1.4%	[1.2%, 1.6%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.3%, 0.6%]	7

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.8%	[-0.8%, -0.8%]	1
Improvements ✅ (secondary)	-1.5%	[-1.5%, -1.5%]	1
All ❌✅ (primary)	-0.8%	[-0.8%, -0.8%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

rylev · 2022-10-11T21:34:37Z

@cjgillot FYI: it appears that indeed #102845 was responsible for the small perf regressions. This is not large enough to warrant any revert, but it might be worth looking into.

Stoozy and others added 18 commits September 26, 2022 13:10

Trying to suggest additional lifetime parameter

887515a

Using multipart suggestion

365457b

Properly formatting the multipart suggestion

24c8e27

Proper span for new generic param suggestion

e7cb6ad

Emitting error regardless of new param suggestion

ef930a2

Removed unnecessary for loop

2657f9d

fix rust-lang#102182, recover from impl Trait in type param bound

7b2f04a

Split slice part of feature(half_open_range_patterns) to [...]_in_slices

c084c26

Stabilize half_open_range_patterns

5ae7363

Elaborate trait ref to compute object safety.

f5fd66e

Add missing documentation for FileNameDisplayPreference variants

550f579

From<Alignment> for usize & NonZeroUsize

0718aec

Rollup merge of rust-lang#102323 - Stoozy:master, r=cjgillot

0db05f1

Trying to suggest additional lifetime parameter ``@cjgillot`` This is what I have so far for rust-lang#100615

Rollup merge of rust-lang#102345 - chenyukang:fix-102182-impl-trait, …

303ebd5

…r=estebank Recover from impl Trait in type param bound Fixes rust-lang#102182 r? ``@estebank``

Rollup merge of rust-lang#102845 - cjgillot:gat-object, r=fee1-dead

a4e5577

Elaborate trait ref to compute object safety. instead of building them manually from supertraits and associated items. This allows to have the correct substs for GATs. Fixes rust-lang#102751

Rollup merge of rust-lang#102862 - scottmcm:more-alignment-traits, r=…

6d35efe

…thomcc From<Alignment> for usize & NonZeroUsize Since you mentioned these two in rust-lang#102072 (comment), r? ``@thomcc`` Tracking Issue: rust-lang#102070

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 10, 2022

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 10, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 10, 2022

bors merged commit e495b37 into rust-lang:master Oct 10, 2022

rustbot added this to the 1.66.0 milestone Oct 10, 2022

JohnTitor deleted the rollup-qnwsajt branch October 10, 2022 06:35

This was referenced Oct 10, 2022

Implement From<bool> for f32, f64 #100390

Merged

suggestions: don't mention other impls of traits with type parameters #102752

Closed

rustbot added the perf-regression Performance regression. label Oct 10, 2022

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 6 pull requests #102867

Rollup of 6 pull requests #102867

JohnTitor commented Oct 10, 2022

JohnTitor commented Oct 10, 2022

bors commented Oct 10, 2022

bors commented Oct 10, 2022

bors commented Oct 10, 2022

rust-timer commented Oct 10, 2022

rust-timer commented Oct 10, 2022

rylev commented Oct 11, 2022

rust-timer commented Oct 11, 2022

rust-timer commented Oct 11, 2022

rylev commented Oct 11, 2022

Rollup of 6 pull requests #102867

Rollup of 6 pull requests #102867

Conversation

JohnTitor commented Oct 10, 2022

JohnTitor commented Oct 10, 2022

bors commented Oct 10, 2022

bors commented Oct 10, 2022

bors commented Oct 10, 2022

rust-timer commented Oct 10, 2022

rust-timer commented Oct 10, 2022

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

rylev commented Oct 11, 2022

rust-timer commented Oct 11, 2022

rust-timer commented Oct 11, 2022

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

rylev commented Oct 11, 2022