-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a benchmark for creating large uninit allocations #3638
Conversation
That is strange. The only docs I can find suggest this should fit comfortably on a GitHub-hosted runner: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories |
Note that on Windows we're using a 32bit target as the host. Not sure how Windows manages the address space there, maybe it keeps half of it for the kernel so there's only 2GB total for the program? |
So probably it would make sense to decrease the allocation size to 1GB if the pointer_width is 32. |
Right. I was trying to avoid doing that because the effect size shrinks, but of course a little loop fixes that. |
How long does the benchmark take (with the fix)? |
rust-lang/rust#125633 landed, but a |
200 ms per iteration with the fix. Without the fix, it's 800 ms per iteration. So I think it would be fair to land this without the fix, because it's already one of our faster benchmarks. |
Makes sense, thanks! |
☀️ Test successful - checks-actions |
Extracted from #3637
I used this program to confirm that rust-lang/rust#125633 has the desired effect.