Add experimental L4re support #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
reviewed
May 7, 2017
src/unix/mod.rs
Outdated
| @@ -16,14 +16,17 @@ pub type cc_t = ::c_uchar; | |||
| pub enum DIR {} | |||
| pub enum locale_t {} | |||
|
|
|||
| #[cfg(not(target_os = "l4re"))] | |||
There was a problem hiding this comment.
We typically prefer to avoid these sorts of #[cfg] annotations in libc wherever possible, mind pushing these structs further down the hierarchy to skip them on l4re?
|
☔ The latest upstream changes (presumably #578) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@humenda looks like there may be a merge conflict? Mind also pushing some more of those |
|
I just realized that there are other efforts to define a separate uclibc target env. I spoke to the author of these lines and agreed with him, that I'll move my changes there. I'll let you know as soon as I'm done and the integration tests work fine.
|
|
Ok sounds good to me! |
This commit introduces a UNIX-alike target for the l4re microkernel operating system. While this system is not a UNIX system at all, it is easiest to use the POSIX interface and hence benefit from common definitions. This version is a very early draft, only the basic data types have been verified and most of the complex data types (structs and unions) have not been ported yet.
|
@bors: r+ Thanks! |
|
📌 Commit 09a04d8 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 1, 2017
Add experimental L4re support This PR introduces a UNIX-alike target for the l4re microkernel operating system. While this system is not a UNIX system at all, it is easiest to use the POSIX interface and hence benefit from common definitions. This version is a very early draft, only the basic data types have been verified and most of the complex data types (structs and unions) have not been ported yet. Thanks to TobiasSchaffner for providing his patched version, to verify some assumptions.
|
💔 Test failed - status-travis |
|
@bors: retry
…On Thu, Jun 1, 2017 at 2:12 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/libc/builds/238416640?utm_source=github_status&utm_medium=notification>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#591 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95AApruD0EagfgYtGRIxdP9eSxt3wks5r_w0fgaJpZM4NTFN_>
.
|
bors
added a commit
that referenced
this pull request
Jun 1, 2017
Add experimental L4re support This PR introduces a UNIX-alike target for the l4re microkernel operating system. While this system is not a UNIX system at all, it is easiest to use the POSIX interface and hence benefit from common definitions. This version is a very early draft, only the basic data types have been verified and most of the complex data types (structs and unions) have not been ported yet. Thanks to TobiasSchaffner for providing his patched version, to verify some assumptions.
|
☀️ Test successful - status-appveyor, status-travis |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Aug 5, 2017
Add L4Re Support in librustc_back Add experimental support for x86_64-unknown-l4re-uclibc target, which covers the L4 Runtime Environment. This pull request contains the changes that have to be made to librustc_back. It follows the changes humenda made in pull request rust-lang/libc#591 to libc. Next steps will be the modifications to the needed libraries. (libstd, liballoc_system, libpanic_abort, libunwind) Thanks to humenda for reviewing.
danielverkamp
pushed a commit
to danielverkamp/libc
that referenced
this pull request
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a UNIX-alike target for the l4re microkernel
operating system. While this system is not a UNIX system at all, it is
easiest to use the POSIX interface and hence benefit from common
definitions.
This version is a very early draft, only the basic data types have been
verified and most of the complex data types (structs and unions) have
not been ported yet.
Thanks to TobiasSchaffner for providing his patched version, to verify some assumptions.