-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add login_tty api from libutil #1313
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
also, if this looks good can i bump the verision |
This LGTM. @bors: r+ I'll bump the version when doing the next release. |
📌 Commit 83ccc7b has been approved by |
💔 Test failed - checks-travis |
@bors: r+ |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit 83ccc7b has been approved by |
☀️ Test successful - checks-cirrus, checks-travis, status-appveyor |
thanks |
No description provided.