Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add login_tty api from libutil #1313

Merged
merged 2 commits into from
Apr 7, 2019
Merged

add login_tty api from libutil #1313

merged 2 commits into from
Apr 7, 2019

Conversation

kkuehlz
Copy link
Contributor

@kkuehlz kkuehlz commented Apr 5, 2019

No description provided.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kkuehlz
Copy link
Contributor Author

kkuehlz commented Apr 5, 2019

also, if this looks good can i bump the verision

@gnzlbg
Copy link
Contributor

gnzlbg commented Apr 7, 2019

This LGTM. @bors: r+


I'll bump the version when doing the next release.

@bors
Copy link
Contributor

bors commented Apr 7, 2019

📌 Commit 83ccc7b has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Apr 7, 2019

⌛ Testing commit 83ccc7b with merge 48c1b13...

bors added a commit that referenced this pull request Apr 7, 2019
add login_tty api from libutil
@bors
Copy link
Contributor

bors commented Apr 7, 2019

💔 Test failed - checks-travis

@gnzlbg
Copy link
Contributor

gnzlbg commented Apr 7, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Apr 7, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Contributor

bors commented Apr 7, 2019

📌 Commit 83ccc7b has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Apr 7, 2019

⌛ Testing commit 83ccc7b with merge 5b989db...

bors added a commit that referenced this pull request Apr 7, 2019
add login_tty api from libutil
@bors
Copy link
Contributor

bors commented Apr 7, 2019

☀️ Test successful - checks-cirrus, checks-travis, status-appveyor
Approved by: gnzlbg
Pushing 5b989db to master...

@bors bors merged commit 83ccc7b into rust-lang:master Apr 7, 2019
@kkuehlz
Copy link
Contributor Author

kkuehlz commented Apr 7, 2019

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants