Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies and propagate tracing features #687

Merged
merged 3 commits into from
Feb 27, 2021

Conversation

detrumi
Copy link
Member

@detrumi detrumi commented Feb 27, 2021

Fixes #686

@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 27, 2021

📌 Commit 49e13f6 has been approved by jackh726

@bors
Copy link
Contributor

bors commented Feb 27, 2021

⌛ Testing commit 49e13f6 with merge 4e3d174...

@bors
Copy link
Contributor

bors commented Feb 27, 2021

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 4e3d174 to master...

@bors bors merged commit 4e3d174 into rust-lang:master Feb 27, 2021
@detrumi detrumi deleted the bump-dependencies branch February 27, 2021 21:28
bors added a commit that referenced this pull request May 10, 2021
fix(chalk-recursive): allow chalk-solve's default-features to be disabled

Without this change, one of the issues mentioned in #686 continue to persist after #687 because `chalk-solve`'s features were enabled unconditionally when depending on `chalk-recursive`.

Now `chalk-solve`'s `tracing-full` feature is enabled when `chalk-recursive`'s `tracing-full` feature is enabled (which it continues to be by default; it may be worth considering disabling these by default in the future, as #686 suggested, to minimize this sort of issue).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tracing-tree gets activated by chalk-recursive
3 participants