Upgrade dependencies (incl. Salsa) #553
Conversation
chalk-integration/src/query.rs
Outdated
| @@ -50,7 +51,7 @@ pub trait LoweringDatabase: RustIrDatabase<ChalkIr> { | |||
| /// cached state becomes invalid, so the query is marked as | |||
| /// volatile, thus ensuring that the solver is recreated in every | |||
| /// revision (i.e., each time source program changes). | |||
| #[salsa::volatile] | |||
| #[salsa::dependencies] | |||
There was a problem hiding this comment.
Hmm, I don't know that this has quite the same semantics. I think this is going to create a fresh solver every time. This was an issue that was raised over on the salsa repo -- that we lost a way to have values that are not Eq.
There was a problem hiding this comment.
So is there a way to work around this, or are we stuck waiting for a solution to the salsa issue?
There was a problem hiding this comment.
Hmm, I don't know that this has quite the same semantics. I think this is going to create a fresh solver every time. This was an issue that was raised over on the salsa repo -- that we lost a way to have values that are not
Eq.
Ah yes, you're right. I was hoping they had the same semantics going off their descriptions, but looking at the source code they definitely aren't the same.
So is there a way to work around this, or are we stuck waiting for a solution to the salsa issue?
We could use a hacky workaround (which @nikomatsakis briefly alluded to). I just pushed some changes that should work, but it's not ideal.
This PR upgrades all dependencies, including upgrading salsa to
0.14. To upgrade salsa, there were some changes needed to account for the removal of thevolatileattribute, so it might be good if someone who knows salsa a bit better double checked this.