Improve detection of msvc environment when compiling from msvc #1310
+59
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlon
force-pushed
the
improve-msvc-check
branch
3 times, most recently
from
5b6b170 to
8bcc286
Compare
|
cc @ChrisDenton can you take a look at this please? (I'm not that familiar with windowd/msvc) |
|
Hmm, I did have to consider this a bit more. On balance, I think I'd rather keep the non-msbuild case the same as it was to avoid unintended side-effects. So ideally this PR would only affect MSBuild. |
|
@ChrisDenton Is this not achieved by checking that Note that this problem does affect building from VS as well, not only msbuild. |
ChrisDenton
reviewed
Dec 4, 2024
ChrisDenton
reviewed
Dec 4, 2024
dlon
force-pushed
the
improve-msvc-check
branch
from
5ff0342 to
4605d62
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1308. This makes path/env detection a bit pickier by not using
PATHif the compiler has an unexpected target. Previously this caused issues for build scripts since rustc always needs to target the native arch.