Implement Debug trait for Scalar type
#578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me, but could you run |
arik-so
force-pushed
the
make-scalars-debuggable
branch
from
62095f4 to
8ed8cac
Compare
|
Sure, done! |
apoelstra
approved these changes
Feb 2, 2023
tcharding
reviewed
Feb 2, 2023
| @@ -23,6 +23,7 @@ use crate::constants; | |||
| #[allow(missing_debug_implementations)] | |||
There was a problem hiding this comment.
This line could have been removed in this patch.
There was a problem hiding this comment.
I'm happy to open a followup PR. Shall I?
There was a problem hiding this comment.
I went ahead and did to save time: #579. If it's just a nuisance PR due to its size, I'm happy to close it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
Scalartypes do not implement theDebugtrait, whereas most other types in the library do. Besides that being an upstream requirement for us, I believe it would also be quite useful for users of that type.Also implements the
Indextraits forScalar.