Deprecate schnorrsig #411
Merged
Deprecate schnorrsig #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
deprecate-schnorrsig
branch
from
d03486c to
cc30497
Compare
|
My bad for using the current release instead of upcoming. On the subject, is there any way to know what the next release version number is going to be? If one follows all PRs should that be obvious? Will update to 0.22.0, thanks. |
Recently we moved from using the identifier 'schnorrsig' to 'schnorr', we omitted to update the schnorr public key size constant. Deprecate `SCHNORRSIG_PUBLIC_KEY_SIZE` and add `SCHONORR_PUBLIC_KEY_SIZE`.
Recently we moved from using the identifier 'schnorrsig' to 'schnorr', we omitted to update the schnorr signature size constant. Deprecate `SCHNORRSIG_SIGNATURE_SIZE` and add `SCHONORR_SIGNATURE_SIZE`.
Recently we moved from using the identifier 'schnorrsig' to 'schnorr', we omitted to update a helper function.
Recently we moved from using the identifier 'schnorrsig' to 'schnorr', we omitted to update the tests. While we are at it use more idiomatic Rust unit test names (i.e., do not start test name with `test_` because it stutters when the name is read in output of `cargo test`).
tcharding
force-pushed
the
deprecate-schnorrsig
branch
from
cc30497 to
7b91f9d
Compare
|
Re-based, only changes were update of 'deprecate since' version. |
apoelstra
approved these changes
Mar 4, 2022
|
No, there is no way to tell what the next version will be :) this crate especially is something of a one-man show and we don't usually have any epics or long-term goals, it's just a question of whether we have breaking API changes in the pipeline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we moved from using the identifier 'schnorrsig' to 'schnorr' but we missed a few places.
Change identifiers to use 'schnorr' instead of 'schnorrsig', deprecate if necessary.
Please note, does not touch
secp256k1-sys. Use of 'schnorrsig' remains insecp256k1-sys,