restore global-context-less-secure feature
#407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
reviewed
Feb 17, 2022
|
Agreed. But I do think we should merge this to put the feature back in place (since it will break compilation to remove it), and then re-remove it for the upcoming major release. |
Merged
|
ACK, removing a feature would be breaking change. |
|
@elichai can I have an ack here |
elichai
approved these changes
Feb 21, 2022
apoelstra
added a commit
that referenced
this pull request
Mar 28, 2022
…l context (fixup for #407) c1bb316 Make global-context-less-secure actually enable the global context (Elichai Turkel) Pull request description: In #407 we restored the `global-context-less-secure` feature, but it didn't actually do anything because #385 changed all the cfg checks on the whole module to depend on `global-context`, so we need to enable `global-context` in order to make that module compile. so before all this, users could enable *just* `global-context-less-secure` without enabling the `global-context`, and after this PR it will behave the same. (this will not enable the randomization because of: https://github.com/rust-bitcoin/rust-secp256k1/blob/1cf2429b12ff06a04a5c882f2f5d918042629660/src/context.rs#L51) ACKs for top commit: apoelstra: ACK c1bb316 Tree-SHA512: edc7b4916b359a0696cc25f498bc52ad340f981ad6b01b83b68966d6179200bac6acb96f5480157e24c605b5552bdd7b6eb8770bc9a2c5734da3df11c021fb5b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't remove a feature in a minor release, and also I believe this feature is actually necessary in some niche applications.