Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push: Fix word matching #1224

Merged
merged 2 commits into from
Jun 24, 2022
Merged

push: Fix word matching #1224

merged 2 commits into from
Jun 24, 2022

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Jun 24, 2022

Preview removed

@zecakeh zecakeh requested a review from a team June 24, 2022 12:45
Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't like all of this stuff being defined on ASCII, it degrades the experience for non-English usage (especially where the language used doesn't use a variation of the latin alphabet).

But that's what the spec says and just deviating from it w/o trying to change it is also pretty bad and would be against existing policy.

So let's merge this but consider an optional unicode mode, and spec change proposal, down the road.

@zecakeh zecakeh merged commit 506a7bd into main Jun 24, 2022
@zecakeh zecakeh deleted the zecakeh/push-word-match branch June 24, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants