This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Don't swallow LoadErrors when requiring a dashed gem #3195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've edited my PR and the first message with improvements |
Intrepidd
force-pushed
the
patch-1
branch
3 times, most recently
from
ef3e601 to
a53c9b7
Compare
|
I also added a spec and fixed existing specs related to that |
This looks like rubygems#1807 when raising a LoadError in a required gem, bundler will rescue it to try and see if it came from his own namespaced require or from the required file. If it comes from the dashed require it will re-raise the original exception in case the gem was dashed but the first require was ok but raised a LoadError after. However, the exception is swallowed if we require a dashed gem without the proper file name, for example gem name : 'foo-bar' and file architecture : 'foo/bar.rb' This PR raise the exception back in case it really comes from inside the namespaced file.
indirect
added a commit
that referenced
this pull request
Oct 3, 2014
Don't swallow LoadErrors when requiring a dashed gem
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like #1807
when raising a LoadError in a required gem, bundler will rescue it to try and see if it came from his own namespaced require or from the required file.
If it comes from the dashed require it will re-raise the original exception in case the gem was dashed but the first require was ok but raised a LoadError after.
However, the exception is swallowed if we require a dashed gem without the proper file name, for example gem name : 'foo-bar' and file architecture : 'foo/bar.rb'
This PR cleans a bit the code (remove useless condition) and fixes the issues with the loading :