Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useToaster): fix the container parameter of toaster.push does not work #4057

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

simonguo
Copy link
Member

@simonguo simonguo commented Dec 3, 2024

fix: #3438

Copy link

codesandbox bot commented Dec 3, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 4:18am
rsuite-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 4:18am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 4:18am

Copy link

codesandbox-ci bot commented Dec 3, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 77b7f95:

Sandbox Source
wonderful-ishizaka-2jyz3h Issue #3438

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.19%. Comparing base (fbdc928) to head (77b7f95).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/toaster/ToastContainer.tsx 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4057      +/-   ##
==========================================
- Coverage   89.19%   89.19%   -0.01%     
==========================================
  Files         504      504              
  Lines       12239    12242       +3     
  Branches     3143     3145       +2     
==========================================
+ Hits        10917    10919       +2     
  Misses        656      656              
- Partials      666      667       +1     
Flag Coverage Δ
ChromeCi 89.13% <87.50%> (-0.01%) ⬇️
Firefox 89.10% <87.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonguo simonguo merged commit c0073c3 into main Dec 5, 2024
15 of 16 checks passed
@simonguo simonguo deleted the fix/useToaster branch December 5, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CustomProvider always overrides Toaster container
1 participant