Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CheckTree): fix the incorrect check state after loading child nodes through getChildren #3974

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

simonguo
Copy link
Member

fix: #3973

Copy link

codesandbox bot commented Sep 20, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 6:09am
rsuite-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 6:09am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 6:09am

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.89%. Comparing base (d3a8bc9) to head (97285a8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3974   +/-   ##
=======================================
  Coverage   96.89%   96.89%           
=======================================
  Files         752      752           
  Lines       24170    24182   +12     
  Branches     3172     3172           
=======================================
+ Hits        23419    23431   +12     
  Misses        670      670           
  Partials       81       81           
Flag Coverage Δ
ChromeCi 96.87% <100.00%> (+<0.01%) ⬆️
Firefox 96.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonguo simonguo merged commit afaaf2d into main Sep 20, 2024
16 checks passed
@simonguo simonguo deleted the fix/CheckTree-getChildren branch September 20, 2024 06:44
@amjadbouhouch
Copy link

Thanks 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CheckTreePicker check items get unchecked after async getChildren call
2 participants