Update example image to how it is currently rendered #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitar
force-pushed
the
image
branch
2 times, most recently
from
cc31f30 to
8ac5965
Compare
|
I added support for file input in 6e8841b |
|
Awesome! |
|
One question. I noticed this because I wanted to compare how my changed colors compare to the default colors. I think my changed colors are much more readable. I wonder if this is something you would entertain that I make a PR and change also for defaults in zerolog:
Changes:
This makes debug and trace messages not stand out (they are all gray) while important ones do (especially important because there are generally many more debug ones). |
|
sure go ahead |
madkins23
pushed a commit
to madkins23/zerolog
that referenced
this pull request
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the image is not how currently default console writer renders it.
The image was done using Ubuntu 20.04 using Gnome Terminal (I think default color settings).
I also made a JSONL file with log entries to be able to generate this in the future using the
prettylogtool.BTW, prettylog tool does not work on files, see my comment here.