Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CallerWithSkipFrameCount to the Context (#98) #135

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Add CallerWithSkipFrameCount to the Context (#98) #135

merged 1 commit into from
Mar 5, 2019

Conversation

mikeyrcamp
Copy link
Contributor

Add the ability to skip a specified number of stack frames
on a per context basis. Before this toe CallerSkipFrameCount
could only be set globally.

context.go Outdated Show resolved Hide resolved
@mikeyrcamp
Copy link
Contributor Author

@rs this PR is good to go whenever you are ready to merge. I adjusted it to react to your changes for #137

log_test.go Outdated Show resolved Hide resolved
log_test.go Outdated Show resolved Hide resolved
context.go Outdated Show resolved Hide resolved
context.go Outdated Show resolved Hide resolved
Add the ability to skip a specified number of stack frames
on a per context basis. Before this toe CallerSkipFrameCount
could only be set globally.
@mikeyrcamp
Copy link
Contributor Author

@rs I incorporated your recommended changes. Thanks again!

@rs rs merged commit 651d361 into rs:master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants