Don't use faint text in colorized console output #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The faint text style doesn't seem to be supported by all terminals, which means the default console output loses most of its coloring on them. This commit changes the color scheme to more widely-supported colors. This also matches how it looked in earlier versions of this library.
kevinmcconnell
commented
Feb 7, 2019
| @@ -27,6 +22,9 @@ const ( | |||
| colorMagenta | |||
| colorCyan | |||
| colorWhite | |||
|
|
|||
| colorBold = 1 | |||
| colorDarkGray = 90 | |||
There was a problem hiding this comment.
I've moved these into the same const block because the only thing they have in common with each other is that they don't fit tidily into the iota sequence. We could pull them back out if that's preferred though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is from discussion in #125.
The faint text style doesn't seem to be supported by all terminals, which means the default console output loses most of its coloring on them.
This commit changes the color scheme to more widely-supported colors. This also matches how it looked in earlier versions of this library.