Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go test all fails when github.com/rs/zerolog is a dependency #137

Closed
ssoroka opened this issue Feb 27, 2019 · 2 comments
Closed

go test all fails when github.com/rs/zerolog is a dependency #137

ssoroka opened this issue Feb 27, 2019 · 2 comments

Comments

@ssoroka
Copy link

ssoroka commented Feb 27, 2019

using go modules, go test all fails when github.com/rs/zerolog is a dependency:

--- FAIL: TestWith (0.00s)
    log_test.go:106: invalid log output:
        got:  {"string":"foo","bytes":"bar","hex":"12ef","json":{"some":"json"},"error":"some error","bool":true,"int":1,"int8":2,"int16":3,"int32":4,"int64":5,"uint":6,"uint8":7,"uint16":8,"uint32":9,"uint64":10,"float32":11.101,"float64":12.30303,"time":"0001-01-01T00:00:00Z","caller":"/usr/local/go/src/testing/testing.go:865"}
        
        want: {"string":"foo","bytes":"bar","hex":"12ef","json":{"some":"json"},"error":"some error","bool":true,"int":1,"int8":2,"int16":3,"int32":4,"int64":5,"uint":6,"uint8":7,"uint16":8,"uint32":9,"uint64":10,"float32":11.101,"float64":12.30303,"time":"0001-01-01T00:00:00Z","caller":"~/go/pkg/mod/github.com/rs/zerolog@v1.11.0/log_test.go:104"}
FAIL
FAIL	github.com/rs/zerolog	0.086s
@rs
Copy link
Owner

rs commented Feb 27, 2019

This test is naive. I'll fix it.

@rs
Copy link
Owner

rs commented Feb 27, 2019

Actually, that's a go 1.12 regression.

@rs rs closed this as completed in 6d6350a Feb 27, 2019
@mikeyrcamp mikeyrcamp mentioned this issue Feb 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ssoroka @rs