Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start handling the various SQLite TEXT types #221

Merged
merged 2 commits into from
Dec 21, 2016
Merged

Conversation

otoolep
Copy link
Member

@otoolep otoolep commented Nov 19, 2016

This is the start of a code change to handle this comprehensively.

@otoolep
Copy link
Member Author

otoolep commented Nov 19, 2016

The code could check the encoding of the database, and perform the correct conversions.
PRAGMA encoding;
PRAGMA encoding = "UTF-8";
PRAGMA encoding = "UTF-16";
PRAGMA encoding = "UTF-16le";
PRAGMA encoding = "UTF-16be";

This is the start of a code change to handle this comprehensively.
Add unit test for concatenated queries. This deals with issue #240 but
this may be a hack. I need to dig into this issue more.
@otoolep otoolep force-pushed the handle_sqlite_datatypes branch from 8bfccf9 to 9a7ff4c Compare December 20, 2016 15:18
@otoolep
Copy link
Member Author

otoolep commented Dec 21, 2016

I'm going to merge this, as I think it's a step in the right direction.

@otoolep otoolep merged commit 91d47d6 into master Dec 21, 2016
@otoolep otoolep deleted the handle_sqlite_datatypes branch December 21, 2016 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant