Consistently use "removing" instead of "erasing" packages #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Fedora user noticed that an output of "dnf remove" command marks transaction actions as "Erasing" instead of "Removing" <https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/GL3RTOI5FUSZUQU3L2PVY2U5LQDB5BDI/>: # dnf remove dontpanic Package Arch Version Repository Size Removing: dontpanic x86_64 1.02-16.fc41 f42-build 49.5 KiB Transaction Summary: Removing: 1 package Is this ok [y/N]: y Running transaction [1/2] Prepare transaction 100% | 15.0 B/s | 1.0 B | 00m00s [2/2] Erasing dontpanic-0:1.02-16.fc41.x8 100% [==================] | 225.0 B/s | 13.0 B | -00m00s >>> Running trigger-post-uninstall scriptlet: glibc-common-0:2.40.9000-1.fc42.x86_64warning: posix.fork(): .fork(), .exec(), .wait() and .redirect2null() are deprecated, use rpm.spawn() or rpm.execute() instead warning: posix.wait(): .fork(), .exec(), .wait() and .redirect2null() are deprecated, use rpm.spawn() or rpm.execute() instead warning: posix.exec(): .fork(), .exec(), .wait() and .redirect2null() are deprecated, use rpm.spawn() o[2/2] Erasing dontpanic-0:1.02-16.fc41.x86_64 100% | 50.0 B/s | 13.0 B | 00m00s Complete! That's not only inconsistent with other "Removing:" and "Removed:" titles, it also promotes "erase" word and people try running "dnf erase" which is an old alias never implemented in DNF5. This patch changes "erase" to "remove" everywhere in the output, a documentation, and code comments where appropriate.
|
It seem a CI test needs to be updated due to the change in the hint. |
ppisar
added a commit
to ppisar/ci-dnf-stack
that referenced
this pull request
Sep 27, 2024
Adapt "--allowerasing is hinted on attempt to install conflicting packages" dnf/resolve-hints.feature scenario to a changed output of the conflict hint. The output was changed in "Consistently use "removing" instead of "erasing" packages" DNF5 commit. Related: rpm-software-management/dnf5#1732
|
Indeed. Adapted CI tests at rpm-software-management/ci-dnf-stack#1557. |
kontura
approved these changes
Sep 27, 2024
Merged
via the queue into
rpm-software-management:main
with commit Sep 27, 2024
ce289e9
16 of 20 checks passed
kontura
pushed a commit
to rpm-software-management/ci-dnf-stack
that referenced
this pull request
Sep 27, 2024
Adapt "--allowerasing is hinted on attempt to install conflicting packages" dnf/resolve-hints.feature scenario to a changed output of the conflict hint. The output was changed in "Consistently use "removing" instead of "erasing" packages" DNF5 commit. Related: rpm-software-management/dnf5#1732
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Fedora user noticed that an output of "dnf remove" command marks transaction actions as "Erasing" instead of "Removing" https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/GL3RTOI5FUSZUQU3L2PVY2U5LQDB5BDI/:
That's not only inconsistent with other "Removing:" and "Removed:" titles, it also promotes "erase" word and people try running "dnf erase" which is an old alias never implemented in DNF5.
This patch changes "erase" to "remove" everywhere in the output, a documentation, and code comments where appropriate.