Fix a use-after-free in EmitterEmail::notify() #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When "dnf5 automatic" was configured to send e-mails via SMTP
("emit_via = email" in automatic.conf), it sometimes crashed:
#0 0x00007ff7fb955184 __memcpy_avx_unaligned_erms (libc.so.6 + 0x147184)
rpm-software-management#1 0x00007ff7fb873bd4 fmemopen_read (libc.so.6 + 0x65bd4)
rpm-software-management#2 0x00007ff7fb875813 _IO_file_underflow@@GLIBC_2.2.5 (libc.so.6 + 0x67813)
rpm-software-management#3 0x00007ff7fb877e45 _IO_default_xsgetn (libc.so.6 + 0x69e45)
rpm-software-management#4 0x00007ff7fb869a40 _IO_fread (libc.so.6 + 0x5ba40)
rpm-software-management#5 0x00007ff7faceb1f7 cr_in_read (libcurl.so.4 + 0x541f7)
rpm-software-management#6 0x00007ff7facf8608 cr_eob_read (libcurl.so.4 + 0x61608)
rpm-software-management#7 0x00007ff7facf0f20 Curl_client_read (libcurl.so.4 + 0x59f20)
rpm-software-management#8 0x00007ff7facf103d Curl_req_send_more (libcurl.so.4 + 0x5a03d)
rpm-software-management#9 0x00007ff7fad068da Curl_readwrite (libcurl.so.4 + 0x6f8da)
rpm-software-management#10 0x00007ff7face6258 multi_runsingle.lto_priv.0 (libcurl.so.4 + 0x4f258)
rpm-software-management#11 0x00007ff7face8c64 curl_multi_perform (libcurl.so.4 + 0x51c64)
rpm-software-management#12 0x00007ff7facbb8a3 curl_easy_perform (libcurl.so.4 + 0x248a3)
rpm-software-management#13 0x00007ff7f9ee30ad _ZN4dnf512EmitterEmail6notifyEv (automatic_cmd_plugin.so + 0x170ad)
rpm-software-management#14 0x00007ff7f9ed61f5 _ZN4dnf516AutomaticCommand3runEv (automatic_cmd_plugin.so + 0xa1f5)
rpm-software-management#15 0x0000557b633d5f78 main (dnf5 + 0x39f78)
rpm-software-management#16 0x00007ff7fb811248 __libc_start_call_main (libc.so.6 + 0x3248)
rpm-software-management#17 0x00007ff7fb81130b __libc_start_main@@GLIBC_2.34 (libc.so.6 + 0x330b)
rpm-software-management#18 0x0000557b633d88e5 _start (dnf5 + 0x3c8e5)
or sent an e-mail without a body and some headers (e.g. Subject):
From root@fedora-41.localdomain Thu Aug 1 14:49:36 2024
Return-Path: <root@fedora-41.localdomain>
X-Original-To: test
Delivered-To: test@fedora-41.localdomain
Received: from fedora-41 (localhost [IPv6:::1])
by fedora-41.localdomain (Postfix) with ESMTP id E5A1E51
for <test>; Thu, 01 Aug 2024 14:49:36 +0200 (CEST)
Message-Id: <20240801124936.E5A1E51@fedora-41.localdomain>
Date: Thu, 01 Aug 2024 14:49:36 +0200 (CEST)
From: root@fedora-41.localdomain
The cause was that a FILE * structure registered to curl as CURLOPT_READDATA
and freed before curl_easy_perform() processed it.
This patch fixes it.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2298385
Merged
via the queue into
rpm-software-management:main
with commit Aug 2, 2024
97ed37c
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When "dnf5 automatic" was configured to send e-mails via SMTP ("emit_via = email" in automatic.conf), it sometimes crashed:
or sent an e-mail without a body and some headers (e.g. Subject):
The cause was that a FILE * structure registered to curl as CURLOPT_READDATA and freed before curl_easy_perform() processed it.
This patch fixes it.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2298385