Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add history redo command #1595

Merged
merged 6 commits into from
Jul 31, 2024
Merged

Add history redo command #1595

merged 6 commits into from
Jul 31, 2024

Conversation

kontura
Copy link
Contributor

@kontura kontura commented Jul 25, 2024

  • Add history redo command
  • Update and enable history docs
  • Allow up/down-grade if NA is already installed

Tests: rpm-software-management/ci-dnf-stack#1531

kontura added 5 commits July 25, 2024 12:47
…ion`

It will be used later for transaction redo.
It adds a new goal API to redo a history transaction.
If a package is already installed in the requested version but with a different reason override the reason.
This is useful when redoing an interrupted transaction.
The longest part of a transaction is running rpm changes, saving reasons is done after rpm finishes. If a transaction
is interrupted in the middle of the rpm part some rpms are changed but reasons are not updated at all. To handle this
enforce the reasons in the selected transaction.
This makes a difference if `--ignore-installed` is set and the package
is installed in a different version -> it upgrades/downgrades the
package to the requested version.

This matches dnf4 behavior.
Copy link
Member

@m-blaha m-blaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@m-blaha
Copy link
Member

m-blaha commented Jul 31, 2024

I ran the tests from rpm-software-management/ci-dnf-stack#1531 locally and everything is passing.

@m-blaha m-blaha added this pull request to the merge queue Jul 31, 2024
Merged via the queue into rpm-software-management:main with commit 00d00c1 Jul 31, 2024
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants