-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: Add skipped packages to the transaction table #1440
Conversation
I'd like to enhance the functionality provided by this function to also process skipped packages. Having the function as a method of Transaction::Impl makes this easier.
get_broken_dependency_packages() - list of packages with broken dependencies get_conflicting_packages() - list of packages that have a conflict
198baa4
to
fdc76cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, I have only couple minor remarks.
Do you want to wait for #1191 or can we merge this before?
libsmartcols does not support spanning cells. Currently, the intertitles in the transaction table (e.g., "Installing:", "Upgrading:",...) are placed into the first column. Unfortunately, these titles for skipped packages are quite long ("Skipping packages with conflicts:" and "Skipping packages with broken dependencies:") and cause the first column to become unnecessarily wide, breaking the transaction table. To resolve this issue, this patch splits the transaction table into several sections and keeps intertitles out of the table. Each section of the table is then printed one at a time with respective titles using the scols_table_print_range() function. However, there are several issues with this approach: - cannot utilize libsmartcols to print table headers. This is workarounded by adding the header manually as the first section of the table. - cannot use the SCOLS_FL_TREE flag for tree-like indentation. This is workarounded by creating indentation manually using spaces.
Unfortunately it doesn't look that it will get merged in near future - with need to also clearly display the vendor changes it might not be possible to put everything on one line. |
Resolves: #359