Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sparkfun-micromod-rp2040 board #24

Merged
merged 4 commits into from
Jun 21, 2023

Conversation

Finomnis
Copy link
Contributor

@Finomnis Finomnis commented May 20, 2023

Adds support for the Sparkfun Micromod RP2040 board.

  • Pin configuration
  • Documentation
  • Example: Blinky
  • Example: Battery Voltage

@Finomnis Finomnis force-pushed the sparkfun_micromod_rp2040 branch from 0ce7f65 to 4e11539 Compare May 20, 2023 20:14
@Finomnis
Copy link
Contributor Author

Finomnis commented May 21, 2023

Board does not start automatically when ATP carrier is powered on, a reset push is required. Needs some investigation before merging.

EDIT: Turns out this was a problem with my USB port.

@Finomnis
Copy link
Contributor Author

Finomnis commented Jun 21, 2023

@jannic Ping. Any reason this is stale? I'm still interested in having this merged :)

Copy link
Member

@9names 9names left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just busy, I'm afraid. Feel free to ping me once a week if it's getting ignored, or ask in the matrix chat.
This looks good to me

@9names 9names merged commit 663c606 into rp-rs:main Jun 21, 2023
@Finomnis Finomnis deleted the sparkfun_micromod_rp2040 branch June 21, 2023 21:21
@Finomnis
Copy link
Contributor Author

@9names Is there anything to do for me now to get this published to crates.io? Or is this an automated process?

@9names
Copy link
Member

9names commented Jun 21, 2023

Not automated.
If we follow what we've done previously: one of the rp-rs folks will publish it the first time, so we can add the team and add you as an author as well (so we can publish in the future if you are no longer active on the project).
If you're planning to hang around it would be good to get you added to a team (and maybe we should have a boards team?) so you can help out with reviews and publishing in the future.

@Finomnis
Copy link
Contributor Author

@9names Sure :) although it turned out in my current project that the RP2040 is not powerful enough, so I switched to a micromod teensy. What I'm trying to say is I'm not currently actively working on a project that requires this crate any more, so I'm not sure how active I will be.

@Finomnis
Copy link
Contributor Author

Finomnis commented Jun 22, 2023

But I have the hardware at home, so if problems arise, I can jump in and maintain.

@jannic
Copy link
Member

jannic commented Jun 22, 2023

I switched to a micromod teensy

Out of curiosity: How was the experience porting your code to the new platform? This looks like an interesting case, where your external peripherals stay the same, but you replace the processor module.

Are the different HALs of the embedded rust ecosystem similar enough that such a change is possible without major refactorings? Or did they already diverge too far? Anything we could do to improve the situation?

@Finomnis
Copy link
Contributor Author

Finomnis commented Jun 22, 2023

Out of curiosity: How was the experience porting your code to the new platform? This looks like an interesting case, where your external peripherals stay the same, but you replace the processor module.

Are the different HALs of the embedded rust ecosystem similar enough that such a change is possible without major refactorings? Or did they already diverge too far? Anything we could do to improve the situation?

The application code stayed the same, but the entire io layer had to be completely rewritten. Well there were further complications because I relied on PIO (it's a neopixel project) and the only way to drive neopixel with teensy is the nxp flexio. Which currently is not supported by the imxrt-hal/ral/teensy4-bsp yet. So I pretty much have pull requests open along the entire stack :D but everyone is super supportive.

@Finomnis
Copy link
Contributor Author

The experience would probably have been more straight forward if my usecase would rely more on the standardized micromod interface, like uart, spi, i2c etc.

@9names
Copy link
Member

9names commented Jun 22, 2023

https://crates.io/crates/sparkfun-micromod-rp2040
I've added you as an owner @Finomnis, you'll have to accept before your name shows up on crates.io

@jannic
Copy link
Member

jannic commented Jun 22, 2023

Thanks for the feedback (and for your contribution, in the first place!)

If you notice something where another HAL has made better API choices than the rp2040 one, please open a ticket or tell us in the matrix chat room.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants