make Python #-style comments parsed as Comment::Single #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'#' comments are single line comments (kinda like // comments in C/C++). Rouge should strip the return line char and display them as such.
dblessing
requested changes
Aug 6, 2018
lib/rouge/lexers/python.rb
Outdated
| @@ -68,7 +68,7 @@ def self.exceptions | |||
| end | |||
|
|
|||
| rule /[^\S\n]+/, Text | |||
| rule /#.*$/, Comment | |||
| rule %r(#(.*)?\n), Comment::Single | |||
There was a problem hiding this comment.
I think we should add a ? after the \n so it's optional to account for the rare case of a comment being on the last line of a file without a newline. It's not super likely to happen but it worked prior to this change so we should preserve that.
There was a problem hiding this comment.
Fine by me, I've updated the PR
dblessing
added
the
author-action
pyrmont
removed
the
author-action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'#' comments are single line comments (kinda like // comments in C/C++). Rouge should strip the return line char and display them as such.
The same should be done for ruby.rb lexer I guess.
Before :
After :