Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for EPP templates (#901) #903

Merged
merged 4 commits into from
Jul 30, 2019
Merged

Add support for EPP templates (#901) #903

merged 4 commits into from
Jul 30, 2019

Conversation

ananace
Copy link
Contributor

@ananace ananace commented Apr 25, 2018 •
edited by pyrmont
Loading

Based off of a lightly modified ERB lexer, just with the added parsing of parameter blocks.

I'm not entirely sure if it's best to just extend the open/close regexps, or to add a completely separate parameters state.

This fixes #901.

@ananace ananace mentioned this pull request Jun 19, 2019
Closed
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Jul 16, 2019
pyrmont
pyrmont suggested changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@pyrmont pyrmont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry it's taken so long to review what's a very simple lexer all things considered! :( I'm afraid since we restarted work on Rouge, we've been going backwards through the outstanding PRs and that meant this one took a while to reach.

Some comments below. Let me know if anything is unclear!

lib/rouge/lexers/epp.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/epp.rb Outdated Show resolved Hide resolved
spec/visual/samples/epp Show resolved Hide resolved
@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed needs-review The PR needs to be reviewed and removed needs-review The PR needs to be reviewed author-action The PR has been reviewed but action by the author is needed labels Jul 29, 2019
@pyrmont pyrmont added dependent-pr The PR is dependent on other changes being merged and will be reviewed later. and removed needs-review The PR needs to be reviewed labels Jul 30, 2019
@pyrmont pyrmont mentioned this pull request Jul 30, 2019
Merged
@pyrmont pyrmont merged commit b898149 into rouge-ruby:master Jul 30, 2019
@pyrmont pyrmont removed the dependent-pr The PR is dependent on other changes being merged and will be reviewed later. label Jul 30, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Jul 30, 2019

@ananace Hey, we got it merged in (eventually)! Yay! 🎉

Rouge is currently on a two-week release schedule so this will come out as part of v3.8.0 next Tuesday. Thanks for your hard work and your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrmont pyrmont pyrmont requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFE: Add support for EPP - Embedded Puppet
2 participants
@ananace @pyrmont