Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #860: sed addresses that use custom delimiter. #893

Merged
merged 2 commits into from
Aug 2, 2019
Merged

Fix issue #860: sed addresses that use custom delimiter. #893

merged 2 commits into from
Aug 2, 2019

Conversation

axiac
Copy link
Contributor

@axiac axiac commented Apr 14, 2018 •
edited by pyrmont
Loading

This fixes #860.

@vidarh vidarh mentioned this pull request Jan 17, 2019
Closed
@pyrmont pyrmont mentioned this pull request May 11, 2019
Merged
@pyrmont pyrmont mentioned this pull request Jun 19, 2019
Closed
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Jul 18, 2019
@pyrmont pyrmont force-pushed the bugfix.860-sed-addresses branch from cdcd8fd to 3915003 Compare August 2, 2019 21:42
@pyrmont pyrmont merged commit 72988bf into rouge-ruby:master Aug 2, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Aug 2, 2019

@axiac Thanks for submitting this fix and I'm sorry that it took so long to get to it. We're on a two-week release cadence as we clear the backlog of outstanding submissions so this will roll out as part of v3.8.0 on Tuesday. Thanks again!

@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handling sed format may hide some text
2 participants
@axiac @pyrmont