Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a first support to EEX (Embedded Elixir) #874

Merged
merged 3 commits into from
Aug 19, 2019
Merged

Conversation

julp
Copy link
Contributor

@julp julp commented Feb 19, 2018

Hi,

this PR attempts to add an initial support to EEX (Embedded Elixir).

Really close to (and based on) the ERB class with a change of rule /.+(?=#{close})|.+/m, Comment to rule /./, Comment to handle one line comments (<%# ... %>).

This fixes #412

Copy link
Contributor

@pyrmont pyrmont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julp I'm sorry it's taken so long to get to this. Due to various changes that have taken place with respect to our CI tests, I've rebased your branch against the current master. I'm sorry if that causes any problems at your end!

Some comments below:

lib/rouge/lexers/eex.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/eex.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/eex.rb Outdated Show resolved Hide resolved
spec/visual/samples/eex Show resolved Hide resolved
@pyrmont pyrmont added dependent-pr The PR is dependent on other changes being merged and will be reviewed later. and removed needs-review The PR needs to be reviewed labels Aug 19, 2019
@pyrmont pyrmont added needs-review The PR needs to be reviewed and removed dependent-pr The PR is dependent on other changes being merged and will be reviewed later. labels Aug 19, 2019
@pyrmont pyrmont merged commit 1ab68f2 into rouge-ruby:master Aug 19, 2019
@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label Aug 19, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Aug 19, 2019

@julp Well, it was a bit of a journey but it's merged in now. Thanks for contributing to making Rouge a better highlighting library :)

We're operating on a two-week cadence for releases with v3.9.0 scheduled for Tuesday 20 August. The EEX lexer will be part of that release 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for EEX (embedded Elixir templates)
2 participants