[Swift] Tuple destructuring, function call with lambda argument #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice - could maybe support backticks around the identifier - currently gives parse errors: (and oops, now I notice the non-destructuring form with backticks gives the wrong syntax type...) In case you haven't seen it there's a spec/visual/samples/swift file where your examples could go. |
|
Good catches! I added examples to the |
dan-zheng
changed the title
dan-zheng
changed the title
|
Cool. Thanks for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added Swift support for tuple destructuring: addresses issue #833.
I also fixed function calls with lambdas as the first argument.
Before:
When tuple destructuring occurs,
let/varare incorrectly parsed as function names instead of keywords.After:
Tuple destructuring is parsed as expected.