Also: <3 Haxe support. Thanks for building this!

Any news on this?

Hi there! What need to be done here to make it merged?

@olleolleolle any guidance here on what needs to be done would be greatly appreciated.

@pyrmont @olleolleolle @jneen Hey guys 👋 any updates on what needs to be done to get this merged? The guys at dev.to use this to syntax highlight their articles and this would be great for all the Haxe posts out there.

@RichardBray Sorry it's taken so long to get to this. I'm afraid that I've been working my way through the PRs in reverse chronological order which admittedly isn't great for the older PRs. I do prioritise ones where there's activity, though, so am happy to move this to the front of my queue! Will take a look on where things are and get back to you :)

Oh, two more things:

1. To get this to work with Travis, you'll need to bring in the new settings for Travis, the Gemfile, the Rake task. Rebasing against master should bring all that stuff in. Once you've done that, you'll be able to run rake at the command line and see the results of the test suite and RuboCop.

2. One of the things that RuboCop will complain about is regular expression literals that can be ambiguous as to whether they are calls to the / method. The general way we've fixed this since your original submission is to move from this rule /.../ to this rule %r/.../. You can of course use other delimiters with %r but that's the change that requires the least amount of work.

Let me know if any of the above or any of the comments are unclear!

Thanks @pyrmont for taking a look at this. I really want to get Haxe support included but my Ruby is rusty :( I will ping @josuigoa to take a look, if I get nothing in a week I'll try and take it myself 🤞

@RichardBray No worries! Let me know if you get stuck!

Hi! I'm going on vacation these days and I couldn't add a better sample. I think all other changes are done. @RichardBray , could you add a proper sample?

@josuigoa Yeah sure, I will see what I can do. Thanks for your work on this so far.

@josuigoa Sorry I wasn't able to edit the samples file from your file so I made a new PR with the changes #1293. Hopefully, you're okay with that. If not we can hold off merge until you're back from vacation.

@josuigoa Ah cool thanks for giving me permission. I'll see if I can push my changes to this PR

@josuigoa @RichardBray I'm sorry for the force push—there's been some important changes made to Rouge's Gemfile and Rake tasks that I wanted to pick up so I've rebased against the current master.

I've corrected some remaining indentation mistakes and added a self.detect? method so that the automatic tests will pass (you can run these yourself by pulling down the rebased repo, making sure your gems are up to date and running rake).

The last thing to check are the errors in the visual sample. If you run rackup, you'll have a web server running locally that you can open and see the way Rouge is lexing the visual sample. You'll see there's problems with the @ character and with regular expressions. I haven't looked closely at the rules to see where the problems are. If it's not obvious, you can wait a little bit and I'll have a look at fixing it.

@pyrmont Hmmm, I guess there must be a rule where if an @ symbol is not in a method or in quotation marks it errors out. They're not essential in the Haxe sample file so I've taken them out in this PR. josuigoa#3

But if someone does want syntax highlighting for a Haxe Macro then there might be an issue 🤔

I guess there must be a rule where if an @ symbol is not in a method or in quotation marks it errors out.

What do you mean? Haxe metas can be used in various places.

@kLabz sorry I meant an error in the rouge lexer not an error with Haxe. I feel like rouge will need to be updated in the future to accommodate the @ symbol being used anywhere.

I'm testing things locally and yeah this version is very limited but I guess that's already better than current state (no highlighting at all)

@kLabz Can you provide some examples (you can just paste them here) that aren't being parsed properly? I'm more inclined to want to fix this while we're reviewing this lexer now than put it off to later.

There's not much missing actually 👍

• String interpolation is not handled at all but that's only a nice-to-have, it doesn't break anything
• Metadata (incorrectly named "haxe macros" here) give errors. Note that with haxe 4 you can have namespaced metadata as in @:some.meta.
• Conditional compilation give errors too. In haxe 4 they can be namespaced too #if abc.def and there's a new semver parsing #if (somelib_ver >= version("1.2.4")).
• Abstracts are partially supported (Some example with from, to and metadata + Operator overloading); seems like only from/to and metadata support are missing.

@kLabz I think I've added all the features you mentioned but let me know if I broke something or if I missed something.

Indeed it works pretty well, thanks!

Thanks for sorting things out and approving this PR @pyrmont. I owe you a coffee when I'm next in Tokyo ☕️

Thanks everyone :) We're on a two-week cadence for releases of Rouge as we go through the backlog of pull requests. The next release (v3.9.0) is scheduled for Tuesday 20 August and this lexer will be included with that version.