Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This is an implementation of a lexer for the Elm language (http://elm-lang.org/).
I've seen that there is a long-running PR for Elm support #552. While its author did a great job in covering basic scenarios, the lexer lacks a support for a lot of Elm features. So after trying to update it, I ended up implementing this new separate lexer version. I've listed main differences of the current implementation below.
For extended example of parsing (i.e.
/spec/visual/samples/elm
) I've used several sources: (1) description of a basic Elm package, that covers basic operators and syntax; (2) elm-compiler test cases that include some edge-case scenarios; (3) examples from the Elm syntax guide.The sample is quite long, but it provides a good coverage of Elm syntax and features.
I've added a lot of comments to the lexer code to make it easier to read by others and to extend it in future.
Here are the main differences of the current version over the #552: