-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve lexers/shell.rb
#716
Conversation
@rindeal Thanks for your work on this! It doesn't look like maintainers have the ability to push code to the relevant branch of your fork so apologies for not being able to make these changes myself. To get the checks to pass, you need to update the MIME type section of it 'guesses by mimetype' do
- assert_guess :mimetype => 'application/x-shellscript'
+ assert_guess :mimetype => 'text/x-sh'
+ assert_guess :mimetype => 'text/x-shellscript'
end In addition, if you could update the list of filename globs in tag 'shell'
aliases 'bash', 'zsh', 'ksh', 'sh'
- filenames '*.sh', '*.bash', '*.zsh', '*.ksh',
- '.bashrc', '.zshrc', '.kshrc', '.profile', 'APKBUILD', 'PKGBUILD'
+ filenames '*.sh', '*.bash', '*.zsh', '*.ksh', '.bashrc', '.zshrc',
+ '.kshrc', '.profile', 'APKBUILD', 'PKGBUILD', '*.ebuild',
+ '*.eclass', '*.exheres-0', '*.exlib' Let me know if anything is unclear! |
`file` utility uses `text/*` mime-types, while Mozilla uses `application/*`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question about the change to the MIME types:
@rindeal Hey, it took two years but we finally got this one closed! 🎉 Thanks for contributing to Rouge :) |
Yes, thank you very much. |
This patches adds support for Gentoo and Exherbo package build recipes. It also sets proper mime-type to shell files.