Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect Containerfiles as Dockerfiles #2059

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Detect Containerfiles as Dockerfiles #2059

merged 1 commit into from
Jul 15, 2024

Conversation

ahills
Copy link
Contributor

@ahills ahills commented Jul 10, 2024

The podman & buildah tools support files named Containerfile in addition to Dockerfile, and the syntax is the same:

A Containerfile uses the same syntax as a Dockerfile internally.

https://docs.podman.io/en/latest/markdown/podman-build.1.html

According to the maintainers, the intent is to keep it the same:

The content, commands, and any features that are usable in a Dockerfile should also be usable in a Containerfile too. That's the design goal.

containers/buildah#3170

This patch simply extends the filename globs to include the alternative filenames & extensions.

@tancnle
Copy link
Collaborator

tancnle commented Jul 15, 2024

Thank you for your contribution @ahills ❤️ LGTM 🚀

@tancnle tancnle added this pull request to the merge queue Jul 15, 2024
Merged via the queue into rouge-ruby:master with commit 04887af Jul 15, 2024
8 checks passed
@ahills ahills deleted the dockerfile-containerfile branch July 25, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants