Improve Python lexer #1919
Merged
Improve Python lexer #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes three changes to the Python lexer: 1) Move the `decorator` rule before the `operator` rule. Before this change, decorators were never getting recognized. This was because if there was ever an `@`, it was always satisfying the `operator` rule. This remedies that by first checking for the `decorator` pattern and then the operator pattern. 2) Recognize functions and classes when they are called. Previously, functions and classes were only recognized when they were defined. With this change, they will also be recognized and styled when they are called. 3) Don't recognize imported modules as `Namespace`s. It is not desirable to highlight imported modules like namespaces. With this change, they are simply recognized as the general `Name` token.
|
@dunkmann00 I will have a look at the PR sometime today. Sorry for the delay 🙇🏼♂️ |
|
@dunkmann00 Thank you for the contribution. The PR looks great to me.
Please let me know what you think about 2 and 3. 🙏🏼 |
tancnle
reviewed
Jan 31, 2023
tancnle
added
author-action
|
@tancnle The added visual samples look great! I added one more to show that classes also get highlighted when they are created.
|
|
Thank you for your effort on this @dunkmann00 🙇🏼 🚀 |
|
Thanks for reviewing, helping, and merging @tancnle! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes three changes to the Python lexer:
Move the
decoratorrule before theoperatorrule.Before this change, decorators were never getting recognized. This
was because if there was ever an
@, it was always satisfying theoperatorrule. This remedies that by first checking for thedecoratorpattern and then the operator pattern.Recognize functions and classes when they are called.
Previously, functions and classes were only recognized when they were
defined. With this change, they will also be recognized and styled
when they are called.
Don't recognize imported modules as
Namespaces.It is not desirable to highlight imported modules like namespaces.
With this change, they are simply recognized as the general
Nametoken.
Remove
selffrom@builtins_pseudoto prevent it from getting styledselfis not a built-in special variable in Python. It is just a local variablethat is customarily used to indicate the calling object on an instance
method. As such, it shouldn't be styled the same as actual built-in
objects.