Update GitHub theme, add dark mode #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the GitHub theme and also adds support for a dark mode. The color values are sourced from the primer/primitives repository. https://github.com/primer/primitives
tancnle
reviewed
Jan 24, 2023
There was a problem hiding this comment.
Thank you for your contribution @dunkmann00 ❤️ The PR looks good overall. I have added some suggestions for your consideration. It would be nice to set the background colour correctly when viewing via the visual tool http://localhost:9292/?theme=github.dark
| Dark | Light |
|---|---|
 |
 |
Please let me know what you think.
|
Hi @tancnle! Thanks for taking a look at this and for offering some suggestions about the background. I've gone ahead and added a background color to the text for both modes. |
|
Thanks, @dunkmann00. Look awesome! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the GitHub theme and also adds support for a dark mode.
The color values are sourced from the primer/primitives repository. https://github.com/primer/primitives
This resolves #1906