Define missing namespace state for haxe lexer #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an exception where namespace state is not defined. - Standardise import, using and package statement - Support import with alias - Distinguish Keyword::Namespace token
|
👋🏼 @MoritzBrueckner I am not an expert in Haxe but this is my attempt to address the reported issue. Please let me know if it looks right to you 🙏🏼 . |
|
Hi, I can't test your changes but it looks correct to me, thanks a lot :) For the import alias I think it's also possible to use |
Added in de9ed46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an exception where the namespace state is not defined.
inandas)Keyword::NamespacetokenFixes #1720