Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support quoted keys in TOML #1777

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Support quoted keys in TOML #1777

merged 1 commit into from
Jan 6, 2022

Conversation

tancnle
Copy link
Collaborator

@tancnle tancnle commented Jan 5, 2022 •
edited
Loading

Add support for quoted keys in TOML.

Extracted from the doc:

Quoted keys follow the exact same rules as either basic strings or literal strings and allow you to use a much broader set of key names. Best practice is to use bare keys except when absolutely necessary.

I have also added some example and verify via the visual test site

Screen Shot 2022-01-05 at 5 16 53 pm

Closes #1632

@tancnle
Support quoted keys for TOML
568feca 
This commit supports quoted keys in standard key/value pair as well as
ones inside inline table.
@tancnle tancnle changed the title Support quoted keys for TOML Support quoted keys in TOML Jan 5, 2022
@tancnle
Copy link
Collaborator Author

tancnle commented Jan 5, 2022 •
edited
Loading

👋🏼 @e-kwsm could you kindly review this PR and see if it addresses the reported issue? 🙏🏼

@e-kwsm
Copy link

e-kwsm commented Jan 5, 2022

@tancnle Thanks, it works as expected. 👍

@tancnle
Copy link
Collaborator Author

tancnle commented Jan 6, 2022

Thanks @e-kwsm 🙇🏼

@tancnle tancnle merged commit 158b6fd into rouge-ruby:master Jan 6, 2022
@tancnle tancnle deleted the toml-quoted-keys branch January 6, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TOML: Quoted Key is allowed to have a space
2 participants
@tancnle @e-kwsm