Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HCL file extensions #1769

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Add HCL file extensions #1769

merged 1 commit into from
Jan 25, 2022

Conversation

maximd
Copy link
Contributor

@maximd maximd commented Dec 1, 2021

Add HCL file extensions

HCL is used in Terraform which uses the .tf file extension but it is already handled by the terraform lexer. But HCL is also used by other Hashicorp tools like:

(in fact the list of HCL Schemas seems to be the most comprehensive list of HCL implementations)

HCL is used in [Terraform which uses the `.tf` file
extension](https://www.nomadproject.io/docs/commands/job/run#examples)
but it is already handled by the [terraform
lexer](https://github.com/rouge-ruby/rouge/blob/master/lib/rouge/lexers/terraform.rb).
But HCL is also used by other Hashicorp tools like:
 * [Packer which uses the `.pkr.hcl`
   extension](https://www.nomadproject.io/docs/commands/job/run#examples)
 * [Vault which uses the `.hcl`
   extension](https://www.vaultproject.io/docs/commands/server#command-options)
 * [Consul which uses the `.hcl`
   extension](https://www.consul.io/docs/agent/options#configuration)
 * [Waypoint which uses the `waypoint.hcl`
   file](https://www.waypointproject.io/docs/waypoint-hcl#project-configuration-waypoint-hcl)
 * [Nomad which uses the `.nomad`
   extension](https://www.nomadproject.io/docs/commands/job/run#examples)
   but also [Nomad Packs which uses the `.hcl`
   extension](https://learn.hashicorp.com/tutorials/nomad/nomad-pack-writing-packs#add-a-new-pack)

(in fact the [list of HCL
Schemas](https://learn.hashicorp.com/tutorials/nomad/nomad-pack-writing-packs#add-a-new-pack)
seems to be the most comprehensive list of HCL implementations)
@maximd
Copy link
Contributor Author

maximd commented Dec 1, 2021

Updated the PR because the .tf file extension is already handled by the terraform lexer.

@tancnle tancnle added the needs-review The PR needs to be reviewed label Jan 12, 2022
@tancnle
Copy link
Collaborator

tancnle commented Jan 25, 2022

Thank you for your contribution @maximd 🙇🏼 The changes look good to me 👍🏼 🚀

@tancnle tancnle merged commit a2af69c into rouge-ruby:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review The PR needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants