Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a full list of supported languages #1739

Merged
merged 3 commits into from
Oct 7, 2021
Merged

Conversation

gdubicki
Copy link
Contributor

Fixes #1738

@gdubicki
Copy link
Contributor Author

I got the list from the input field in http://rouge.jneen.net/ .

@gdubicki
Copy link
Contributor Author

gdubicki commented Oct 7, 2021

Can I get a review please, @jneen / @dblessing / @gfx ? :)

@tancnle
Copy link
Collaborator

tancnle commented Oct 7, 2021

Thanks @gdubicki. This is a great change ❤️. The list might results in a lot of scrolling so I would suggest moving it to a separate file (ie. LANGUAGES.md) and just include a reference here in the README. What do you think?

@gdubicki
Copy link
Contributor Author

gdubicki commented Oct 7, 2021

Thanks for the suggestion @tancnle , this is how Pygments do it too. Done.

@gdubicki
Copy link
Contributor Author

gdubicki commented Oct 7, 2021

Of course it would be better to automatically generate that list, f.e. with some task around here http://github.com/gdubicki/rouge/blob/9a4b79b16530a540bf17771be0e5e4ab4c210d79/tasks/generate/docs.rake#L3-L6 . Sadly I don't know this project well enough to suggest how to do it.

@tancnle tancnle merged commit 32f16f9 into rouge-ruby:master Oct 7, 2021
@tancnle
Copy link
Collaborator

tancnle commented Oct 7, 2021

@gdubicki

Of course it would be better to automatically generate that list, f.e. with some task around here http://github.com/gdubicki/rouge/blob/9a4b79b16530a540bf17771be0e5e4ab4c210d79/tasks/generate/docs.rake#L3-L6 . Sadly I don't know this project well enough to suggest how to do it.

That would be super nice 👍🏼 . Let's ticket it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List all supported languages & unify their number shown in GitHub and on the website
2 participants