Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partially update Dart lexer with newer keywords and types #1691

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Partially update Dart lexer with newer keywords and types #1691

merged 1 commit into from
Jan 25, 2022

Conversation

parlough
Copy link
Contributor

The Dart language has gone through a lot of changes since this lexer was last updated.

This change adds most of the new keywords and core built in types.

You can find more information on Dart's language tour: https://dart.dev/guides/language/language-tour

@parlough
Copy link
Contributor Author

Is there anything I can do to help get these changes in? Thanks!

@tancnle tancnle added the needs-review The PR needs to be reviewed label Jan 25, 2022
@tancnle
Copy link
Collaborator

tancnle commented Jan 25, 2022 •
edited
Loading

Thank you for your contribution @parlough 🙇🏼 Sorry to take a long time to get it back to you 🙏🏼

The PR looks great to me 🚀

@tancnle tancnle merged commit 3542334 into rouge-ruby:master Jan 25, 2022
@parlough
Copy link
Contributor Author

Thanks @tancnle!

@parlough parlough deleted the misc/update-dart-lexer branch January 25, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-review The PR needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parlough @tancnle