Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RML language #1659

Merged
merged 8 commits into from
Aug 7, 2022
Merged

Add support for RML language #1659

merged 8 commits into from
Aug 7, 2022

Conversation

pie-catt
Copy link
Contributor

Add support for RML language.
https://rmlatdibris.github.io/

RML is a rewriting-based and system agnostic Domain Specific Language for Runtime Verification which decouples monitoring from instrumentation by allowing users to write specifications and to synthesize monitors from them, independently of the System Under Scrutiny (SUS) and its instrumentation.

RML has been developed and is currently maintained by DIBRIS - University of Genoa

RML_sample

@tancnle tancnle added the needs-review The PR needs to be reviewed label Mar 3, 2022
Fixed dataExp_with state and indentation warnings from rake tests
@pie-catt
Copy link
Contributor Author

Hello @tancnle. Are there any updates on this? Thank you for your work

@tancnle
Copy link
Collaborator

tancnle commented Jul 21, 2022

Thanks for the ping @pie-catt. I will have a look at it this week. Thank you for your patience. Really appreciated 🙇🏼

@tancnle tancnle self-assigned this Jul 21, 2022
Copy link
Collaborator

@tancnle tancnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @pie-catt ❤️ I have added some suggestions for your consideration. Could you also add an entry to the Languages.md doc? Please let me know what you think.

lib/rouge/lexers/rml.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/rml.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/rml.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/rml.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/rml.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/rml.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/rml.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/rml.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/rml.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/rml.rb Outdated Show resolved Hide resolved
@tancnle tancnle added the author-action The PR has been reviewed but action by the author is needed label Jul 28, 2022
@tancnle tancnle removed their assignment Jul 28, 2022
Fixed code indentation, renamed variables names to snake-case, removed superfluous and closing comments. Added language entry in Languages.md file
@pie-catt
Copy link
Contributor Author

pie-catt commented Aug 6, 2022

Thank you so much for your support @tancnle 🙏🏼. I updated my pull request with your suggestions. I fixed code indentation, renamed variables names to snake-case, removed superfluous and closing comments. I also added RML language entry in Languages.md file. Thank you for your work

@tancnle
Copy link
Collaborator

tancnle commented Aug 7, 2022

Thank you for considering the suggestions @pie-catt 🙇🏼 LGTM. Let's launch this into orbit 🚀

@tancnle tancnle merged commit 61a9cdf into rouge-ruby:master Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author-action The PR has been reviewed but action by the author is needed needs-review The PR needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants