Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SPARQL unicode names support (fix #1653) #1654

Merged
merged 3 commits into from
Jan 26, 2022
Merged

Fix SPARQL unicode names support (fix #1653) #1654

merged 3 commits into from
Jan 26, 2022

Conversation

jakubklimek
Copy link
Contributor

Fix for #1653

@tancnle tancnle added the needs-review The PR needs to be reviewed label Jan 6, 2022
Copy link
Collaborator

@tancnle tancnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @jakubklimek ❤️. The PR looks good overall 👍🏼 I have left a small suggestion for your consideration. Please let me know what you think 🙏🏼

lib/rouge/lexers/sparql.rb Outdated Show resolved Hide resolved
@tancnle tancnle added author-action The PR has been reviewed but action by the author is needed and removed needs-review The PR needs to be reviewed labels Jan 25, 2022
Co-authored-by: Tan Le <tan.le@hey.com>
lib/rouge/lexers/sparql.rb Outdated Show resolved Hide resolved
Co-authored-by: Tan Le <tan.le@hey.com>
@tancnle
Copy link
Collaborator

tancnle commented Jan 26, 2022

Thank you @jakubklimek. Let's merge 🚀

@tancnle tancnle merged commit 75fcbff into rouge-ruby:master Jan 26, 2022
@jakubklimek
Copy link
Contributor Author

@tancnle Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author-action The PR has been reviewed but action by the author is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants